🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

This PR fixes a latent bug in toQueryParams and adds test coverage that surfaced it, plus a small performance improvement to createHttpRequestFromQueryLists.

Bug fix: string enum arrays serialised as integers

Root cause

In .NET the CLR applies array variance for enum types: any array of an int32-backed enum (e.g. Status[]) can be matched by a | :? int32[] pattern. In toQueryParams the concrete | :? array<int32> arm therefore fired for every such enum array — before the generic Array guard that was meant to handle enums.

For integer enums this gave the right answer by accident (the integer string).
For string enums (annotated with [<JsonConverter(typeof<JsonStringEnumConverter>)>]) it silently discarded the wire-name lookup and returned the underlying integer instead:

// Before: Status.Active (= 0) in an array → "0"  ❌
// After:  Status.Active (= 0) in an array → "active"  ✓

Fix

Add a dedicated enum-array arm that fires before all the concrete array<T> arms in toQueryParams:

| :? Array as xs when (let et = xs.GetType().GetElementType() in not(isNull et) && et.IsEnum) ->
    let serializer = enumSerializerCache.GetOrAdd(elTy, enumSerializerFactory)
    [ for i in 0..xs.Length-1 do
          let param = serializer(xs.GetValue(i))
          if not(isNull param) then yield name, param ]

This uses the cached buildEnumSerializer per element type, so both integer and string enums are serialised correctly. The existing | :? Array fallback for DateOnly/TimeOnly arrays is unchanged.

Performance: createHttpRequestFromQueryLists (Task 8)

Replaced the explicit ResizeArray accumulation loop with Seq.concat, which lazily flattens the nested sequences without an intermediate heap allocation. createHttpRequest already filters nulls in its own loop, so the redundant null check was also removed.

// Before
let queryParams = ResizeArray<string * string>()
for queryParamList in queryParamLists do
    for name, value in queryParamList do
        if not(isNull value) then queryParams.Add(name, value)
createHttpRequest httpMethod address queryParams

// After
createHttpRequest httpMethod address (Seq.concat queryParamLists)

New tests (5)

All in ToQueryParamsTests:

Test Status

• Build: ✅ 0 errors, 0 new warnings
• Unit tests: ✅ 517 passed, 0 failed, 1 pre-existing skip (Schema_ParserTests.Fail to parse — no samples)
• Format: ✅ Fantomas check passes

Generated by 🌈 Repo Assist, see workflow run. Learn more.

gh aw add githubnext/agentics/workflows/repo-assist.md@e15e57b40918dbca11b350c55d02ab61934afa75